Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support public rsc pin read, using manual board #147

Merged
merged 7 commits into from
Sep 13, 2022
Merged

feat!: support public rsc pin read, using manual board #147

merged 7 commits into from
Sep 13, 2022

Conversation

machow
Copy link
Collaborator

@machow machow commented Jul 20, 2022 •
edited
Loading

  • Adds support for reading public RStudio Connect pin content, using board_manual.
  • Cleans up how board_manual constructs paths to pins.

@machow
Copy link
Collaborator Author

machow commented Sep 8, 2022 •
edited
Loading

@isabelizimm let's look over this PR tomorrow, and see if it works for accessing public RSC pins in vetiver (we may need to tweak vetiver's from_pin method, or support pin_versions in the URL board)

This was referenced Sep 9, 2022
Closed
Merged
@machow machow marked this pull request as ready for review September 13, 2022 14:40
@machow
Copy link
Collaborator Author

machow commented Sep 13, 2022

The failing test should be resolved by #155 -- going to merge, so we can release in a little bit

@machow machow merged commit 2cec93a into main Sep 13, 2022
@isabelizimm isabelizimm deleted the feat-rsc-public branch November 14, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@machow