Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix release checklist (pool 0.1.2) #50

Merged
merged 10 commits into from Nov 2, 2017
Merged

Hotfix release checklist (pool 0.1.2) #50

merged 10 commits into from Nov 2, 2017

Conversation

bborgesr
Copy link
Contributor

@bborgesr bborgesr commented Oct 13, 2017

Code completion (this PR)

Release checklist (new PR, no code changes there)

  • Create a new branch for the release, like v0.1.2-rc
  • Run devtoools::check() and address any possible problems
  • Bump version to 0.1.2 in NEWS and DESCRIPTION
  • Commit and push to github
  • Download “clean” copy of package and build source package
  • Upload to CRAN
  • When accepted to CRAN:
    • create an annotated tag for the "version bump” commit
    git tag -a v0.1.2 -m "pool 0.1.2 on CRAN"
    git push --tags
    • create and normal-merge a PR for the new release branch

Writing

  • Draft blog post
  • Merge blog post: https://github.com/rstudio/blog/pull/57
  • Update articles in shiny-dev-center
    • Make sure to include all relevant info from original README and original articles
    • Incorporate @slopp's feedback:
      • use case for creating a pool inside the server function (and scoping in general)
      • Rmd documents and how to connect to a database from within one
      • scaling across R projects

… made. Previsouly, this chunk of code was misplaced and it would result in buggy behavior: namely, once the maximum number of objects was reached, no more objects could be checked out (EVEN IF YOU RETURNED ANY/ALL OBJECTS back to the pool)
…s` in DESCRIPTION (because I use it in an example); typo fixes
@bborgesr bborgesr merged commit 7955437 into master Nov 2, 2017
@bborgesr bborgesr deleted the hotfix branch November 2, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant