Hotfix release checklist (pool 0.1.2) #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code completion (this PR)
... = ...
to...
)stop("Maximum number of objects in pool has been reached")
(currently throwing errors when it shouldn't)difftime
everywhere, per Fix for determining interval for validating objects #48 (also, include NEWS item with credit to @caewok)\dontrun
in the Rd-filesdbplyr
functions are wrapped inpool
(including the deprecated ones, see Enable db_write_table() to append to tables, (per deprecation) tidyverse/dbplyr#40 (comment)). Edit: as of today (25/10/2017), there's no.DBIConnection
methods declared in eitherdplyr
ordbplyr
that are not also wrapped inpool
.Release checklist (new PR, no code changes there)
v0.1.2-rc
devtoools::check()
and address any possible problems0.1.2
in NEWS and DESCRIPTIONgit tag -a v0.1.2 -m "pool 0.1.2 on CRAN" git push --tags
Writing