Skip to content

add package-lock.json so npm install can actually install serverless and other dependencies. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

add package-lock.json so npm install can actually install serverless and other dependencies. #3

merged 2 commits into from
May 7, 2021

Conversation

jforest
Copy link
Contributor

@jforest jforest commented May 6, 2021 •
edited
Loading

Or, instead, should I just change the deps to npm install serverless and its plugins?

@jforest jforest requested a review from stevenolen May 6, 2021 18:21
@stevenolen
Copy link
Contributor

you can check in the lock file, but what you're actually looking for is the packages.json file, ala https://github.com/rstudio/revdepcheck-cloud/blob/master/package.json

@stevenolen
Copy link
Contributor

or even... https://github.com/rstudio/r-builds/blob/master/package.json

@jforest jforest merged commit 8e3f756 into main May 7, 2021
@jforest jforest deleted the need-package-lock-for-npm-install branch May 7, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenolen stevenolen stevenolen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jforest @stevenolen