-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to require unique app names #538
Comments
If we're automatically generating the app name, shouldn't we always make it unique? i.e. is there some reason we need to make this a user facing argument? |
The only remaining exception is bookdown.org, which uses the content name to automatically construct its vanity URL. See |
Hmmm, I think different parts of rsconnect make different assumptions about what should happen if there's an existing deployment with the current name:
I think we need to pick one of these two principles and stick to it, otherwise the package is going to inevitably be inconsistent. (Personally, I'd be in favour of assuming we want to update an existing deployment, and minimise as much of the |
And it occurs to me that the default |
Oooh, but it does, implicitly, because |
* No longer use `appTitle` * Make the reasoning behind use of `recordPath` more clear * Only munge for shinyApps * Deprecates `generateAppName()` Fixes #538
* No longer use `appTitle` * Make the reasoning behind use of `recordPath` more clear * Only munge for shinyApps Fixes #538
Our app name generator allows an operation mode wherein unique app names are required:
https://github.com/rstudio/rsconnect/blob/main/R/title.R#L32
However, every call site for this function in
deployApp
passes "FALSE" to that parameter.We should add an option to permit changing this behavior such that non-unique names produce deployment errors.
The text was updated successfully, but these errors were encountered: