Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploySite does not work for non-RMarkdown sites #813

Closed
omar-rs opened this issue Apr 18, 2023 · 7 comments · Fixed by #834
Closed

deploySite does not work for non-RMarkdown sites #813

omar-rs opened this issue Apr 18, 2023 · 7 comments · Fixed by #834
Labels
bug an unexpected problem or unintended behavior deploy ⛹️
Milestone

Comments

@omar-rs
Copy link
Contributor

omar-rs commented Apr 18, 2023

deploySite() looks specifically for static files and directories generated with rmarkdown, so it will not work for sites generated by Quarto because the static artifacts are slightly different.

@hadley
Copy link
Member

hadley commented Apr 18, 2023

Looks like this should be a straightforward fix to a regex: https://github.com/rstudio/rsconnect/blob/envvars/R/deploySite.R#L80

@hadley hadley added bug an unexpected problem or unintended behavior deploy ⛹️ labels Apr 18, 2023
@omar-rs
Copy link
Contributor Author

omar-rs commented Apr 18, 2023

And possibly here too:

siteGenerator <- rmarkdown::site_generator(siteDir)

@hadley
Copy link
Member

hadley commented Apr 18, 2023

Ah yeah, we basically need something to parallel rmarkdown::site_generator() that extracts the equivalent info from the quarto metadata.

@omar-rs
Copy link
Contributor Author

omar-rs commented Apr 18, 2023

Maybe the quarto R package might be able to provide this info via quarto::quarto_inspect()

@aronatkins
Copy link
Contributor

Also related: quarto::quarto_publish_site. https://quarto-dev.github.io/quarto-r/reference/quarto_publish_doc.html

@hadley
Copy link
Member

hadley commented Apr 18, 2023

Ah yes, the first task is to figure out who should own this code.

@hadley hadley added this to the 1.0.0 milestone May 2, 2023
@hadley
Copy link
Member

hadley commented May 3, 2023

I talked with @jjallaire about this, and I think long term goal is to have this code live in rsconnect.

hadley added a commit that referenced this issue May 3, 2023
hadley added a commit that referenced this issue May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior deploy ⛹️
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants