Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay longer before dimming opacity when spinners are active #4062

Merged
merged 4 commits into from
May 23, 2024

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented May 23, 2024

Also syncs the --shiny-spinner-delay with the opacity transition

@cpsievert cpsievert requested a review from gadenbuie May 23, 2024 16:48
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (paired in writing this and reviewed together)

@cpsievert cpsievert merged commit 4a8400d into main May 23, 2024
12 checks passed
@cpsievert cpsievert deleted the opacity-transition-fix branch May 23, 2024 16:52
@github-actions github-actions bot restored the opacity-transition-fix branch May 23, 2024 16:52
cpsievert added a commit to posit-dev/py-shiny that referenced this pull request May 28, 2024
cpsievert added a commit to posit-dev/py-shiny that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants