Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay longer before dimming opacity when spinners are active #4062

Merged
merged 4 commits into from
May 23, 2024
Merged

Delay longer before dimming opacity when spinners are active #4062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23b54b2
make sure to delay and transition the change in opacity when busy ind…
cpsievert May 23, 2024
5ff155d
better approach
cpsievert May 23, 2024
c94f7fa
Fix
cpsievert May 23, 2024
c9efd0d
Delay a touch longer
cpsievert May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/www/shared/busy-indicators/busy-indicators.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions srcts/extras/busy-indicators/busy-indicators.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
--_shiny-spinner-url: var(--shiny-spinner-url, url(spinners/ring.svg));
--_shiny-spinner-color: var(--shiny-spinner-color, var(--bs-primary, #007bc2));
--_shiny-spinner-size: var(--shiny-spinner-size, 32px);
--_shiny-spinner-delay: var(--shiny-spinner-delay, 750ms);
--_shiny-spinner-delay: var(--shiny-spinner-delay, 1s);

background: var(--_shiny-spinner-color);
width: var(--_shiny-spinner-size);
Expand All @@ -25,8 +25,10 @@
mask-image: var(--_shiny-spinner-url);
-webkit-mask-image: var(--_shiny-spinner-url);

opacity: 0;
animation-delay: var(--_shiny-spinner-delay);
animation-name: fade-in;
animation-duration: var(--_shiny-spinner-delay);
animation-duration: 250ms;
}

/*
Expand All @@ -37,6 +39,7 @@
opacity: 1;
> *:not(.recalculating) {
opacity: 0.2;
transition: opacity 250ms ease var(--shiny-spinner-delay, 1s);
}

/*
Expand Down Expand Up @@ -116,9 +119,6 @@
0% {
opacity: 0;
}
67% {
opacity: 0;
}
100% {
opacity: 1;
}
Expand Down
Loading