Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STEP8 MapManagerのリファクタリング #11

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

ShotaAk
Copy link

@ShotaAk ShotaAk commented Jun 12, 2023

What does this implement/fix?

MapManagerクラスに下記の変更を実施します。

  • 関数宣言と実装の順番をヘッダーファイルとソースファイルで一致させる
  • 未使用の関数を削除
  • MapManager内のみで使用している関数をprivateに変更

Does this close any currently open issues?

いいえ

How has this been tested?

ローカルとCI上でビルドが通ることを確認しています。

Any other comments?

STEP13の修正は別PRで実施します

Checklists

ShotaAk added 2 commits June 12, 2023 11:55
map_manager内でしか使用しない関数をprivateに変更
@ShotaAk ShotaAk added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Jun 12, 2023
@ShotaAk ShotaAk requested a review from aoki-rt June 12, 2023 04:23
@github-actions
Copy link

Memory usage change @ 71472ed

Board flash % RAM for global variables %
esp32:esp32:esp32s3 🔺 0 - +4 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board uROS_STEP1_LED
flash
% uROS_STEP1_LED
RAM for global variables
% uROS_STEP2_SWITCH
flash
% uROS_STEP2_SWITCH
RAM for global variables
% uROS_STEP3_Buzzer
flash
% uROS_STEP3_Buzzer
RAM for global variables
% uROS_STEP4_Sensor
flash
% uROS_STEP4_Sensor
RAM for global variables
% uROS_STEP5_Straight
flash
% uROS_STEP5_Straight
RAM for global variables
% uROS_STEP6_rotate
flash
% uROS_STEP6_rotate
RAM for global variables
% uROS_STEP7_P_control
flash
% uROS_STEP7_P_control
RAM for global variables
% uROS_STEP8_micromouse
flash
% uROS_STEP8_micromouse
RAM for global variables
% uROS_STEP10_twistMsg
flash
% uROS_STEP10_twistMsg
RAM for global variables
% uROS_STEP11_tfMsg
flash
% uROS_STEP11_tfMsg
RAM for global variables
% uROS_STEP12_SensorMsg
flash
% uROS_STEP12_SensorMsg
RAM for global variables
% uROS_STEP13_micromouse
flash
% uROS_STEP13_micromouse
RAM for global variables
%
esp32:esp32:esp32s3 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 4 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,uROS_STEP1_LED<br>flash,%,uROS_STEP1_LED<br>RAM for global variables,%,uROS_STEP2_SWITCH<br>flash,%,uROS_STEP2_SWITCH<br>RAM for global variables,%,uROS_STEP3_Buzzer<br>flash,%,uROS_STEP3_Buzzer<br>RAM for global variables,%,uROS_STEP4_Sensor<br>flash,%,uROS_STEP4_Sensor<br>RAM for global variables,%,uROS_STEP5_Straight<br>flash,%,uROS_STEP5_Straight<br>RAM for global variables,%,uROS_STEP6_rotate<br>flash,%,uROS_STEP6_rotate<br>RAM for global variables,%,uROS_STEP7_P_control<br>flash,%,uROS_STEP7_P_control<br>RAM for global variables,%,uROS_STEP8_micromouse<br>flash,%,uROS_STEP8_micromouse<br>RAM for global variables,%,uROS_STEP10_twistMsg<br>flash,%,uROS_STEP10_twistMsg<br>RAM for global variables,%,uROS_STEP11_tfMsg<br>flash,%,uROS_STEP11_tfMsg<br>RAM for global variables,%,uROS_STEP12_SensorMsg<br>flash,%,uROS_STEP12_SensorMsg<br>RAM for global variables,%,uROS_STEP13_micromouse<br>flash,%,uROS_STEP13_micromouse<br>RAM for global variables,%
esp32:esp32:esp32s3,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,4,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@aoki-rt
Copy link
Contributor

aoki-rt commented Jun 12, 2023

ソースファイルの順番が入れ替わっていることを確認した。

@aoki-rt aoki-rt merged commit e108fc5 into main Jun 12, 2023
@ShotaAk ShotaAk deleted the fix_map_manager branch June 12, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants