Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STEP12 MapManagerのリファクタリング #17

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Conversation

ShotaAk
Copy link

@ShotaAk ShotaAk commented Jun 19, 2023

What does this implement/fix?

#11
と同様の変更です。

MapManagerクラスに下記の変更を実施します。

  • 未使用の関数を削除
  • 関数宣言と実装の順番をヘッダーファイルとソースファイルで一致させる
  • MapManager内のみで使用している関数をprivateに変更

Does this close any currently open issues?

いいえ

How has this been tested?

CIでビルドが通ることを確認します。

Any other comments?

Checklists

@ShotaAk ShotaAk added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Jun 19, 2023
@ShotaAk ShotaAk requested a review from aoki-rt June 19, 2023 05:55
@github-actions
Copy link

Memory usage change @ 0806da3

Board flash % RAM for global variables %
esp32:esp32:esp32s3 🔺 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board uROS_STEP1_LED
flash
% uROS_STEP1_LED
RAM for global variables
% uROS_STEP2_SWITCH
flash
% uROS_STEP2_SWITCH
RAM for global variables
% uROS_STEP3_Buzzer
flash
% uROS_STEP3_Buzzer
RAM for global variables
% uROS_STEP4_Sensor
flash
% uROS_STEP4_Sensor
RAM for global variables
% uROS_STEP5_Straight
flash
% uROS_STEP5_Straight
RAM for global variables
% uROS_STEP6_rotate
flash
% uROS_STEP6_rotate
RAM for global variables
% uROS_STEP7_P_control
flash
% uROS_STEP7_P_control
RAM for global variables
% uROS_STEP8_micromouse
flash
% uROS_STEP8_micromouse
RAM for global variables
% uROS_STEP9_twistMsg
flash
% uROS_STEP9_twistMsg
RAM for global variables
% uROS_STEP10_tfMsg
flash
% uROS_STEP10_tfMsg
RAM for global variables
% uROS_STEP11_SensorMsg
flash
% uROS_STEP11_SensorMsg
RAM for global variables
% uROS_STEP12_micromouse
flash
% uROS_STEP12_micromouse
RAM for global variables
%
esp32:esp32:esp32s3 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0
Click for full report CSV
Board,uROS_STEP1_LED<br>flash,%,uROS_STEP1_LED<br>RAM for global variables,%,uROS_STEP2_SWITCH<br>flash,%,uROS_STEP2_SWITCH<br>RAM for global variables,%,uROS_STEP3_Buzzer<br>flash,%,uROS_STEP3_Buzzer<br>RAM for global variables,%,uROS_STEP4_Sensor<br>flash,%,uROS_STEP4_Sensor<br>RAM for global variables,%,uROS_STEP5_Straight<br>flash,%,uROS_STEP5_Straight<br>RAM for global variables,%,uROS_STEP6_rotate<br>flash,%,uROS_STEP6_rotate<br>RAM for global variables,%,uROS_STEP7_P_control<br>flash,%,uROS_STEP7_P_control<br>RAM for global variables,%,uROS_STEP8_micromouse<br>flash,%,uROS_STEP8_micromouse<br>RAM for global variables,%,uROS_STEP9_twistMsg<br>flash,%,uROS_STEP9_twistMsg<br>RAM for global variables,%,uROS_STEP10_tfMsg<br>flash,%,uROS_STEP10_tfMsg<br>RAM for global variables,%,uROS_STEP11_SensorMsg<br>flash,%,uROS_STEP11_SensorMsg<br>RAM for global variables,%,uROS_STEP12_micromouse<br>flash,%,uROS_STEP12_micromouse<br>RAM for global variables,%
esp32:esp32:esp32s3,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0

@aoki-rt
Copy link
Contributor

aoki-rt commented Jun 19, 2023

step8と比較して同等であることを確認しました。

@aoki-rt aoki-rt merged commit 3048ee0 into main Jun 19, 2023
@ShotaAk ShotaAk deleted the refactor_step12 branch June 10, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants