Skip to content
This repository has been archived by the owner on Oct 6, 2024. It is now read-only.

EAG import fine tuning and password reset flow cleanup #1243

Merged
merged 59 commits into from
May 1, 2021

Conversation

viktor-yunenko
Copy link
Member

@viktor-yunenko
Copy link
Member Author

viktor-yunenko commented Apr 12, 2021

Although I can clean up few strings before the review.

@viktor-yunenko viktor-yunenko removed the request for review from sebgrebe April 12, 2021 09:05
@sebgrebe
Copy link
Collaborator

image

Minor/optional: Can we can "eahub.org" in the signature to "EA Hub" or "The EA Hub Admins" or maybe even one of our names, e.g., Vaidehi's?

@sebgrebe
Copy link
Collaborator

Password reset flow looks fine

<p class="error">
Unfortunately this password reset url isn't valid anymore.
Please try to <a href="{% url "account_reset_password" %}">reset your password here</a>,
or reach out to the support at contact@eahub.org.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rather tech@eahub.org.?

Also, we should set this in environment variables or with django singleton (don't need to do this now)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend reserving tech@ for technical matters only, eg sentry or DNS monitoring.

Ideally I would put there support@eahub.org, but looks like it wasn't set up.

Would that make sense to you?

@viktor-yunenko
Copy link
Member Author

Minor/optional: Can we can "eahub.org" in the signature to "EA Hub" or "The EA Hub Admins" or maybe even one of our names, e.g., Vaidehi's?

I would like to. This isn't our email though, it comes with the allauth package. I guess it's a lover priority comparing to other things as SSO and stuff? I'll create a ticket though.

@viktor-yunenko viktor-yunenko merged commit 1318cfb into default May 1, 2021
@viktor-yunenko viktor-yunenko deleted the 1242-eag-import-and-tags-merging branch May 1, 2021 19:07
@sebgrebe sebgrebe mentioned this pull request May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants