Skip to content

feat: allow empty diff when 'renderNothingWhenEmpty' enabled #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2023
Merged

feat: allow empty diff when 'renderNothingWhenEmpty' enabled #143

merged 1 commit into from
Jan 1, 2023

Conversation

Ps7ch3
Copy link
Contributor

@Ps7ch3 Ps7ch3 commented Dec 11, 2022

When '--renderNothingWhenEmpty' enabled, don't fail even if content is empty.

Closes: #141

$ diff -u README.md README.md | ./bin/diff2html --renderNothingWhenEmpty -i stdin -s side -F /tmp/diff.html && echo 'OK'
OK
$ echo $?
0

And empty diff content page is generated
image

@Ps7ch3
feat: allow empty diff when 'renderNothingWhenEmpty' enabled
9d078f8 
When '--renderNothingWhenEmpty' enabled, don't fail even if content is
empty.

Closes: rtfpessoa#141
@rtfpessoa rtfpessoa merged commit 46681d0 into rtfpessoa:master Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'--renderNothingWhenEmpty' didn't work when using 'stdin' as input
2 participants
@Ps7ch3 @rtfpessoa