Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better styling syntax #5

Open
rtsao opened this issue Nov 30, 2016 · 1 comment
Open

Better styling syntax #5

rtsao opened this issue Nov 30, 2016 · 1 comment

Comments

@rtsao
Copy link
Owner

rtsao commented Nov 30, 2016

The current styletron babel plugin is a bit clunky.

A few ideas

  1. Just intercept the style prop and use a global singleton styletron instance under the hood
  2. Use a "styled-components" helper function
@rtsao
Copy link
Owner Author

rtsao commented Jan 11, 2017

I'm now thinking option 1 is the better option here since the only time a global singleton is problematic is with rendering within iframes, which isn't really a common use case. Then everything is just plain JSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant