Patch tracker catchup #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SUFFIX to override lib/lib64 installation path autodetection. Specifying LIB_SUFFIX 'foo' will cause libraries to be installed to install_prefix/libfoo/
…ithout opening the GUI
…yer without PLAYER_GRAPHICS2D_CMD_MULTILINE. The multiline message was added in Player SVN leading up to version 3.1, this maintains compatibility for 3.0 and earlier.
|
I'm trying to merge this change, and it's looking good, except libstage/model_bumper is missing - looks like you forgot to 'git add' it. Send me an email when it's there and I'll try again. cheers, - rtv |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through and applied some of the more recent patches that have been sitting on the patch tracker. I tried to keep each patch in its own commit to make it easier for you to cherry-pick changes, but towards the end the patches stopped applying cleanly and I'd have to fix some of the fuzz after I made the commit. This seemed like a good place to stop and send you a pull request; Stage builds, runs, and lots of bugs are fixed (notably the libstageplugin unsubscription/resubscription issues.) I'm still working through some of the older patches (restore bumper support, camera support in lsp, etc.,) but a lot of them need to be forward-ported to Stage 3.2. Seems as good a time as any to familiarize myself with Stage's inner workings.
I can take care of closing bugs on the patch tracker when they make it into the master branch.