Build fixes and libdir additions #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headers to PRFIX/lib64 (looks for /etc/redhat-release) - Made LIB_SUFFIX a separate variable - users can now override OS detection by specifiying -DLIB_SUFFIX="" or -DLIB_SUFFIX="64" on the command line. - Re-enabled libstageplugin options - Added the FLTK_LDFLAGS for stagebinary to Linux - it seems that apple has a problem with linking libraries twice, but many newer linux systems are now configured so they will not inherit the FLTK libraries that libstage was linked against.
Conflicts: libstage/model_wifi.cc
Tested bumper model with player plugin: visualization indicates when bumpers are activated, and Player plugin reports 1/0 w.r.t. bumper status.
…n and Stage interface are working
|
Any thoughts on this pull request? |
|
Closing for now...reworking so changes apply cleanly to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the issues that Marcin pointed out on the ps-users mailing list. I've also edited some of the documentation for the models to make them look a little nicer when doxygen parses the model options and descriptions. Finally, I've added smarter checking of where to install libraries (lib vs lib64) and added a LIB_SUFFIX option to make it easy to override with one option