Spongify/2022 01 25 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Relates to github bcgit#986
…ng from inputStream
…, and ran it, renaming a bunch of files
These are some of the files/dirs (that you wouldn't want to check-in to source-control) that I see after getting the gradle-build going:
On Android, the dependencies make supporting bc-mail very hard. Previously I did an rm -Rf on the 'mail' folder of bc, but actually, just removing the include from settings is way more Git-friendly for rebasing.
These tests fail: * BasicClientAuthTlsTest.testClientAuthTlsConnection * BasicTlsTest.testBasicTlsConnection ...seems to be due to a provider-lookup failure
…Java 8 The Bouncy Castle project has dozens of javadoc errors which doclint tolerated under Java 7 but are now fatal under Java 8. When releasing to Maven Central (using `gradle uploadArchives`) the `javadoc` task gets run, and will fail when running under Java 8, blocking the release. The solution here was taken from Stephen Colebourne's blog: http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html See also: http://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.html#quiet Several of the javadoc errors in Bouncy Castle are valid - for instance: ``` core/src/main/java/org/bouncycastle/pqc/crypto/mceliece/McElieceCipher.java:160: error: exception not thrown: java.lang.Exception * @throws Exception if the cipher text is invalid. ``` You can quickly see these by running `gradle javadoc` under Java 8.
…tle class The error was for the `org.bouncycastle.jce.provider.JCERSAPublicKey` class: ``` junit.framework.AssertionFailedError: Serialisation: Exception: java.lang.ClassNotFoundException: org.bouncycastle.jce.provider.JCERSAPublicKey at junit.framework.Assert.fail(Assert.java:57) at junit.framework.TestCase.fail(TestCase.java:227) at org.spongycastle.jce.provider.test.AllTests$SimpleTestTest.testJCE(AllTests.java:46) ```
…ed a few of the tests that dealt with serialization; didn't like the class packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spongified the most recent version of BouncyCastle. The old version didn't merge very well, so I tried to redo what was done to the old version. I think it worked - it works in the app I was building. Do you want to merge this somehow?