Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Test>Test Explorer>Add>Test Method #2763

Closed
IvenBach opened this issue Mar 1, 2017 · 3 comments
Closed

Unit Test>Test Explorer>Add>Test Method #2763

IvenBach opened this issue Mar 1, 2017 · 3 comments
Assignees
Labels
bug Identifies work items for known bugs critical Marks a bug as a must-fix, showstopper issue difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. feature-unit-testing status-norepro The issue could not be reproduced. If there is a stable repro, please add that as a new comment. up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky

Comments

@IvenBach
Copy link
Member

IvenBach commented Mar 1, 2017

Adds the method wherever the cursor is active. This may have it add it to an existing method creating

Public Sub SomeTest()
    dim someVar as string
    someVar = "someValue"

Public Sub AnotherTest()

End Sub

End Sub
@retailcoder retailcoder added bug Identifies work items for known bugs critical Marks a bug as a must-fix, showstopper issue difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. feature-unit-testing labels Mar 1, 2017
@retailcoder
Copy link
Member

Really?!! Wow, how did we miss that!

@retailcoder retailcoder added this to the Release 2.0.12 milestone Mar 1, 2017
@comintern
Copy link
Contributor

Pretty sure this was related to the UI thread lag I just fixed by moving to asych events. This needs to be retested after my next PR.

@Vogel612 Vogel612 added the up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky label Mar 2, 2017
@retailcoder retailcoder added the status-norepro The issue could not be reproduced. If there is a stable repro, please add that as a new comment. label Mar 5, 2017
retailcoder added a commit to retailcoder/Rubberduck that referenced this issue Mar 5, 2017
@retailcoder retailcoder self-assigned this Mar 5, 2017
@retailcoder
Copy link
Member

I don't think we can repro this. The AddTestMethodCommand implementation adds the code at the end of the module:

module.InsertLines(module.CountOfLines, body);

It works off the active codepane, but the CanExecute implementation only returns true when the SelectedVBComponent is a test module. Because the Execute implementation works off the ActiveCodePane and not the SelectedVBComponent, I've changed CanExecute to work off the ActiveCodePane as well, but this shouldn't affect it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies work items for known bugs critical Marks a bug as a must-fix, showstopper issue difficulty-01-duckling Issue where no particularly involved knowledge of the internal API is needed. feature-unit-testing status-norepro The issue could not be reproduced. If there is a stable repro, please add that as a new comment. up-for-grabs Use this label in conjunction with a difficulty level label, e.g. difficulty-02-ducky
Projects
None yet
Development

No branches or pull requests

4 participants