1.1.0 regression bug

[gunta]

1.0.1 works
1.1.0 breaks
latest commit breaks

Example:

<span translate>Some text</span>

I can reproduce it in some parts of my app.

What I get in 1.0.1 (correct):

Einige Text

What I get in 1.1.0 (bug):

Einige TextSome text

So basically the original text doesn't get removed from the element.

[rubenv]

Do you have a jsFiddle example? There was someone else complaining about this, but I (currently) have no idea how to reproduce this.

[gunta]

I think it will take some time because I'm only getting this in some parts of the app.

But I will try to locate which commit was the one that breaks.

[circlingthesun]

I saw this behaviour 1.0.1 when changing the language outside of the $digest cycle.

[gunta]

@rubenv @circlingthesun
Hi! I found which commit caused this regression. It's this one: baa95c0bb4f588bd4d9b888a9f80d02ea1305ff8.

All previous commits work OK, all commits after this one present the regression.

I was able to reproduce it when using custom directives on the parent element:

For example this breaks:

<button class="btn" ladda>
    <span translate> Some text</span>
</button>

But this works:

<button class="btn" ladda translate> Some text</span>
</button>

[rubenv]

Could you make a jsFiddle example of the bug?

[gunta]

I'm trying in jsFiddle but sadly cannot reproduce it in a small test case.

It only happens in some parts of the application.

Looking at the commit diff it looks like it might be some kind of compiling/linking order problem.

[carlosgalindo]

Please see my comment @ #161 (comment)

[rubenv]

This should be fixed by v2.1.0. Please test it. If it doesn't work: let us know.