Prevent errors in find-file-hook--open-junk-file #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffer-file-name can become nil even when opened through find-file. For example, [nov.el] (an EPUB reader) does this to disable autosaves. Instead of emitting the error, treat encountering an error as the file not being a junk file, and proceed. nov.el: https://github.com/wasamasa/nov.el
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buffer-file-nameはファイルがfind-fileより開いたときもnilにさせられていることがあります。例えば、nov.elはこうして自動保存を無効にできています(https://github.com/wasamasa/nov.el/blob/ecbdecc927a3b3f7e0927d225e6e6464c244c2ae/nov.el#L720)：このとき、
find-file-hook--open-junk-fileのfile-truenameからエラーが出てしまいます。こんなファイルやバッファーがjunk fileであることはないと思うので、エラーが出たら無視してフックも実行しないようにしました。