Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

MelissaGraham
Copy link
Contributor

No description provided.

@MelissaGraham
Copy link
Contributor Author

A demonstration of why we must pass extent to imshow is provided in this NB:
https://github.com/rubin-dp0/cet-dev/blob/main/MLG_sandbox/plot_RaDec_Coadd_DP01.ipynb

@kadrlica
Copy link
Contributor

kadrlica commented May 2, 2022

Thanks, I'll take a look at this. Your extent solution seems reasonable, but there may be a cleaner way to do it with the WCS itself.

@kadrlica
Copy link
Contributor

kadrlica commented May 5, 2022

I dug around a bit. It looks like afw.display also deals with the WCS, but doesn't have grid lines implemented (however, in an interactive plot it will give you mouse coordinates in a world coordinate system). I think that afw.display is dealing with the CRPIX offset in a similar way to what you are doing, but in this case setting an origin and bbox based on the image.PARENT (some display_matplotlib code here).

This PR looks good to me, though we may eventually get some push back that we should be using afw.display instead of imshow directly.

@kadrlica kadrlica self-requested a review May 5, 2022 21:56
@kadrlica kadrlica merged commit 4c2f655 into main May 5, 2022
@MelissaGraham MelissaGraham deleted the tickets/PREOPS-1174 branch June 16, 2022 23:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants