This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Fix typo in TAP sample query. #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"mag_g, mag_i mag_i, mag_g_cModel" -> "mag_g, mag_r, mag_i, mag_g_cModel" This wasn't caught because a. The Notebook just tests for number of rows returned. b. The query interpreter apparently accepts "mag_g, mag_i mag_i, mag_g_cModel" -> "mag_g, mag_i, mag_g_cModel" instead of throwing an error. Reflow query to make the structure more obvious.
|
@kadrlica if you can review, resolve conflicts with any of your recent updates to that NB for the bump, and get the fix into main in advance of our PR to prod for Patch Thur? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"mag_g, mag_i mag_i, mag_g_cModel" -> "mag_g, mag_r, mag_i, mag_g_cModel"
This wasn't caught because
a. The Notebook just tests for number of rows returned.
b. The query interpreter apparently accepts "mag_g, mag_i mag_i, mag_g_cModel" -> "mag_g, mag_i, mag_g_cModel" instead of throwing an error.
Reflow query to make the structure more obvious.