-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuboCop is broken with Parser 2.5.1.1 #6092
Comments
@whitequark any insight you can bring to this ☝️ would be highly appreciated. |
Parsing the following with class Foo < Bar
end Result:
|
I confirm. Rubocop check is telling us that most of our production code has Ruby syntax errors, which of course it's not true. In case you need more information, please ask. Thank you all. 😄 |
I'll issue a fix for RuboCop in a moment. (just ignore this broken parser version) |
0.58.1 is out. |
@bbatsov TYVM 🎉 |
…by-swandale Fix broken rubocop task by upgrading to 0.58.1 # Description: The problem is a broken parser release (2.5.1.1). Rubocop 0.58.1 skips this bad release so upgrading fixes the problem. An alternative is to explicitly install the previous version of parser, but I see no harm in upgrading. See rubocop/rubocop#6092. # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
This version includes a bugfix (rubocop/rubocop#6092) that should allow us to add PayPal-related code to the RuboCop checks. For this patch, though, only RuboCop is upgraded (and a tiny tweak to Mercury implemented to handle a new RuboCop test); the PayPal compliance changes will be a separate commit.
This version includes a bugfix (rubocop/rubocop#6092) that should allow us to add PayPal-related code to the RuboCop checks. For this patch, though, only RuboCop is upgraded (and a tiny tweak to Mercury implemented to handle a new RuboCop test); the PayPal compliance changes will be a separate commit.
Parser 2.5.1.1 was released two hours ago and it breaks RuboCop.
Expected behavior
RuboCop works fine with both parser 2.5.1.0 and 2.5.1.1
Actual behavior
RuboCop gives very odd results with 2.5.1.1. Also, 37 of its tests fail.
Steps to reproduce the problem
Once parser 2.5.1.1 is installed:
RuboCop version
Include the output of
rubocop -V
. Here's an example:The text was updated successfully, but these errors were encountered: