Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build error #280

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Fix a build error #280

merged 1 commit into from
Feb 25, 2024

Commits on Feb 25, 2024

  1. Fix a build error

    This PR resolves the following CI error with RuboCop 1.35.0:
    
    ```console
      1) RuboCop Project requiring all of `lib` with verbose warnings enabled emits no warnings
         Failure/Error: expect(warnings).to eq []
    
           expected: []
                got: ["/home/runner/work/rubocop-ast/rubocop/lib/rubocop/formatter/html_formatter.rb:6:
    warning: base64 wa...l no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.\n"]
    
           (compared using ==)
    
           Diff:
           @@ -1 +1,2 @@
           +/home/runner/work/rubocop-ast/rubocop/lib/rubocop/formatter/html_formatter.rb:6: warning:
    base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0.
    Add base64 to your Gemfile or gemspec.\n
    
         # ./spec/project_spec.rb:284:in `block (3 levels) in <top (required)>'
    ```
    
    https://github.com/rubocop/rubocop-ast/actions/runs/8033104014/job/21943241393
    
    It updates RuboCop to 1.57.2, which was finally resolved by rubocop/rubocop#12313.
    koic committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    5ad1fcf View commit details
    Browse the repository at this point in the history