[Fix #282] Remove Prism from runtime dependency #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#282. This PR removes Prism from runtime dependency. If it is decided that Prism will not be a runtime dependency for the time being, error message and documentation will be used to communicate the dependency on Prism to users. Making it a default runtime dependency will be avoided until at least rubocop#282 installation error with Prism is resolved.
koic
force-pushed
the
remove_parser_from_runtime_dependency
branch
from
3bf7d20
to
102c5df
Compare
sambostock
reviewed
Mar 1, 2024
Comment on lines
+290
to
+292
| require 'prism' | ||
| rescue LoadError | ||
| warn "Error: Unable to load Prism. Add `gem 'prism'` to your Gemfile." |
There was a problem hiding this comment.
Do we need to enforce a minimum version?
There was a problem hiding this comment.
There is no need to specify a minimum version, as using the latest version is sufficient. Additionally, it is not always possible to align the development status of Prism with intentions behind released warning of rubocop-ast. So, this approach to warnings is the same as that for gemified Ruby standard libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282.
This PR removes Prism from runtime dependency.
If it is decided that Prism will not be a runtime dependency for the time being, error message and documentation will be used to communicate the dependency on Prism to users.
Making it a default runtime dependency will be avoided until at least #282 installation error with Prism is resolved.