Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oh, haven't seen this; awesome! Yeah, we should migrate to this new API.
Originally posted by @palkan in #28 (comment)
Not ready at all but I'll put this up now anyways so you can see what I'm up to. For now I have updated the preprocess tests to pass with the new api.
The really nice part of this is that you provide multiple code ranges, so there's no way that two codeblocks interact with eachother, like in #26.
A whole bunch of busywork is not needed anymore, like keeping track of the
config_store
. TheProcessedSource
has everything you need. In addition the rubocop cache should just work, though I don't know for certain. There's a test for that, so let's just see if that passes.TODO: