Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #113] Fix an error for Minitest/AssertEqual #114

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

koic
Copy link
Member

@koic koic commented Dec 24, 2020

Fixes #113.

This PR fixes an error for Minitest/AssertEqual and some cops when using assert with block argument.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#113.

This PR fixes an error for `Minitest/AssertEqual` and some cops
when using `assert` with block argument.
@koic koic merged commit 5fbab8b into rubocop:master Dec 25, 2020
@koic koic deleted the fix_an_error_for_minitest_assert_equal branch December 25, 2020 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of Minitest Cops errors when used with minitest-power_assert
1 participant