Add new Rails/RelativeDateGrammar
cop
#1106
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
Rails/RelativeDateGrammar
cop.It checks whether the word orders of relative dates
are grammatically easy to understand.
This check includes detecting undefined methods on Date(Time) objects.
Although the resulting value is the same,
1.day.since(Time.current)
is grammatically easier to understand.1.day.since(Time.current)
is a natural extension of1.day.since
.As the receiver and the argument get more complicated, this difference
becomes larger. This cop forces more understandable style, and thus,
assists easier development.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.