Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #214] Fix an error for Rails/UniqueValidationWithoutIndex #218

Merged

Conversation

koic
Copy link
Member

@koic koic commented Mar 26, 2020

Fixes #214.

This PR fixes an error for Rails/UniqueValidationWithoutIndex when a table has no column definition.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#214.

This PR fixes an error for `Rails/UniqueValidationWithoutIndex`
when a table has no column definition.
@koic koic force-pushed the fix_error_for_unique_validation_without_index branch from 44a753e to fdeeba5 Compare March 27, 2020 18:02
@koic koic merged commit 3ba2b30 into rubocop:master Mar 29, 2020
@koic koic deleted the fix_error_for_unique_validation_without_index branch March 29, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in Rails/UniqueValidationWithoutIndex
1 participant