Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12] Allow passing boolean literals to touch #232

Merged
merged 1 commit into from
Apr 12, 2020

Conversation

eugeneius
Copy link
Contributor

Fixes #12.

The Rails/SkipsModelValidations cop currently incorrectly registers an offense for the touch method from Shoulda Matchers' associations DSL:

it { is_expected.to belong_to(:user).touch(true) }

Active Record's touch method accepts attribute names, so we can treat touch calls that pass boolean literal arguments as false positives.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

The `Rails/SkipsModelValidations` cop currently incorrectly registers an
offense for the `touch` method from Shoulda Matchers' associations DSL:

    it { is_expected.to belong_to(:user).touch(true) }

Active Record's `touch` method accepts attribute names, so we can treat
`touch` calls that pass boolean literal arguments as false positives.
@koic koic merged commit c8f3e0c into rubocop:master Apr 12, 2020
@koic
Copy link
Member

koic commented Apr 12, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails/SkipsModelValidations is inconsistence with touch
2 participants