Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #499] Add IgnoreWhereFirst to Rails/FindBy cop #502

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 3, 2021

Fixes #499.

This PR add IgnoreWhereFirst option (true by default) to Rails/FindBy cop.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

Fixes rubocop#499.

This PR add `IgnoreWhereFirst` option (`true` by default) to `Rails/FindBy` cop.
@koic koic force-pushed the add_ignore_where_first_option_for_rails_find_by branch from 3cefa3d to b546468 Compare June 3, 2021 02:45
@koic koic merged commit 434c574 into rubocop:master Jun 5, 2021
@koic koic deleted the add_ignore_where_first_option_for_rails_find_by branch June 5, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rails::FindBy should not flag where.first by default. Make it an option.
1 participant