Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for RSpec/ExampleLength configuration option CountAsOne: [method_call] #1729

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

ydah
Copy link
Member

@ydah ydah commented Oct 3, 2023

Fix: #1728


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • [-] Added tests.
  • Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@Darhazer
Copy link
Member

Darhazer commented Oct 3, 2023

The option method_call appeared in Rubocop 1.40. Should we also update rubocop-rspec to require minimum 1.40 (currently 1.33) for rubocop? Otherwise documentation will be potentially misleading

@ydah
Copy link
Member Author

ydah commented Oct 3, 2023

@Darhazer Indeed it is, I updated this PR. Thank you!

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ydah ydah merged commit e609b2a into master Oct 4, 2023
22 checks passed
@ydah ydah deleted the fix/1728 branch October 4, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSpec/ExampleLength supports undocumented method_call as CountAsOne value
3 participants