Change CI configuration #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix indentation (according to yamllint) 2. Don't run CI on all push & pull request events. Pushing a commit to an open pull request would run each job twice. With the new configuration, we run CI once when opening a PR, and once when pushing a commit that belongs to a pull request. And once when merging to master (the `push` event). Importantly, this configuration still works for contributions from forked repositories, since the `pull_request` events are triggered on _our_ fork.
bquorning
force-pushed
the
change-ci-configuration
branch
from
1714546
to
f7a194d
Compare
|
Fixes #10. |
mikegee
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on: [push, pull_request]caused us to run each job twice every time someone push a commit to an open pull request.With the new configuration, we run CI once when opening a PR, and once when pushing a commit that belongs to a pull request. And once when merging to master (the
pushevent). Importantly, this configuration still works for contributions from forked repositories, since thepull_requestevents are triggered on our fork.