Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #12310] Drop base64 gem from runtime dependency #12313

Merged
merged 1 commit into from
Oct 26, 2023
Merged

[Fix #12310] Drop base64 gem from runtime dependency #12313

merged 1 commit into from
Oct 26, 2023

Commits on Oct 25, 2023

  1. [Fix rubocop#12310] Drop base64 gem from runtime dependency 

    Fixes rubocop#12310.

This PR drops `base64` gem from runtime dependency.

RuboCop only uses `Base64.encode64` from the `base64` gem. Therefore, there's no need to depend on
the entire `base64` gem. The implementation of `Base64.encode64` is quite simple:
https://github.com/ruby/base64/blob/v0.1.1/lib/base64.rb#L27-L40

This change is a better approach that has also been adopted by rack/rack#2110.
    @koic
    koic committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    7399b2e View commit details
    Browse the repository at this point in the history