Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup of new cop names in cop docs #7500

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Conversation

maxh
Copy link
Contributor

@maxh maxh commented Nov 11, 2019

A few minor cleanups related to the good work by @scottmatthewman on #7077.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
Copy link
Member

koic commented Nov 12, 2019

JRuby matrix is failing. Can you rebase with latest master?

@maxh
Copy link
Contributor Author

maxh commented Nov 12, 2019

JRuby matrix is failing. Can you rebase with latest master?

Done in 9feb243. Fingers crossed!

@koic koic merged commit 419fa53 into rubocop:master Nov 13, 2019
@koic
Copy link
Member

koic commented Nov 13, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants