Fix an obsoletion misconfig that inadvertently blocks use of Layout/FirstParameterIndentation
#7503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In April 2019, "Add IndentFirstArgument and IndentFirstParameter" #6982 forked the existing
FirstParameterIndentation
cop into two and added new argument-related functionality.A few weeks ago, these two cops were renamed as part of broad renaming effort (#7077), and it just so happened
IndentFirstParameter
now has the name of the old pre-forked cop.https://github.com/rubocop-hq/rubocop/pull/7468/files#diff-a19f978b95beb4caeb1831d6bef7e443R11
The obsoletion config now thinks the two forked cops are the same, but they are not. When I try to run RuboCop locally from master against our codebase, I get this spurious warning:
This PR should fix that.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.