Fix a false positive for Style/TrailingBodyOnMethodDefinition
#9548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a false positive for `Style/TrailingBodyOnMethodDefinition` when endless method definition body is after newline in opening parenthesis.
|
Probably we should also add some examples with endless methods to the cop's description, but that's unrelated to the fix itself. |
koic
deleted the
fix_false_positive_for_style_trailing_body_on_method_definition
branch
koic
added a commit
to koic/rubocop
that referenced
this pull request
Mar 5, 2021
Follow rubocop#9548 (comment). This PR adds example for `Style/TrailingBodyOnMethodDefinition`.
koic
added a commit
to koic/rubocop
that referenced
this pull request
Mar 5, 2021
Follow rubocop#9548. I noticed redundancy when writing `Style/TrailingBodyOnMethodDefinition` cop's example description.
bbatsov
pushed a commit
that referenced
this pull request
Mar 5, 2021
Follow #9548 (comment). This PR adds example for `Style/TrailingBodyOnMethodDefinition`.
bbatsov
pushed a commit
that referenced
this pull request
Mar 5, 2021
Follow #9548. I noticed redundancy when writing `Style/TrailingBodyOnMethodDefinition` cop's example description.
This was referenced Mar 6, 2021
Closed
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a false positive for
Style/TrailingBodyOnMethodDefinitionwhen endless method definition body is after newline in opening parenthesis.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.