fixed integer overflow on big designs #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubund
added a commit
that referenced
this pull request
Jun 2, 2015
fixed integer overflow on big designs
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to place the AES microprocessor from openCores, and graywolf got hung up in an infinite loop. Tracked it down to an integer overflow---the total wire length exceeds a 32 bit value. There's another bug here that's getting fixed, too, where graywolf used a value (define) "OVER_HEAD" to pad out an array, but then would expand into that array assuming that it wouldn't exceed that overhead and write outside of the array. But again, for a large design like the AES, I found it doing just that, and had to add code to specifically check for out-of-bounds access and increase the array size when necessary.