Skip to content

Add support for if-unused and if-empty for delete_queue #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shashankmehra
Copy link
Contributor

@shashankmehra shashankmehra commented Jan 29, 2024

From HTTP API docs

When DELETEing a queue you can add the query string parameters if-empty=true and / or if-unused=true. These prevent the delete from succeeding if the queue contains messages, or has consumers, respectively.

This PR adds supports for providing these query parameters and the tests to confirm the behaviour.

@michaelklishin
Copy link
Member

According to the diff, this PR does modify some existing tests and that's it.

@michaelklishin
Copy link
Member

Hm, now I see more recent changes, not sure what happened to the Files changes tab.

@michaelklishin michaelklishin merged commit 29ecbce into ruby-amqp:main Jan 29, 2024
@michaelklishin
Copy link
Member

Thank you!

@michaelklishin michaelklishin added this to the 2.3.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants