Skip to content

Fixing command existence detection on Windows. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2015
Merged

Fixing command existence detection on Windows. #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/av/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def method_missing name, *args, &block
end

def detect_command(command)
command = "if command -v #{command} 2>/dev/null; then echo \"true\"; else echo \"false\"; fi"
command = self.system_based_detect_command(command)
result = ::Av.run(command)
case result
when /true/
Expand All @@ -29,5 +29,13 @@ def detect_command(command)
return false
end
end

def system_based_detect_command(command)
if Gem.win_platform?
"#{command} -version 2>NUL && echo true || echo false"
else
"if command -v #{command} 2>/dev/null; then echo \"true\"; else echo \"false\"; fi"
end
end
end
end