Compare benchmarks on commits graph

[bmarkons]

New feature: Compare graphs for two different benchmarks.

Take a closer look at discussion.

[robin850]

Nice work Marko ! 👏

[robin850]

Pretty nit-picky but maybe you could add surrounding spaces around braces.

[robin850]

Also nit-picky but it seems more idiomatic to align the break with the block's content in JavaScript.

[robin850]

As @tgxworld suggested earlier, you could indent this by a level.

Also, to be honest I didn't test it but there should be a way to make this method a little bit easier to read. What do you think about something like:

def build_columns
  columns = {}

  if @comparing_runs.present?
    runs = (@benchmark_runs + @comparing_runs)
             .sort_by { |run| run.initiator.created_at }
  else
    runs = @benchmark_runs
  end
    
  runs.each do |run|
    version = nil
    if block_given?
      version = yield(run)
      @categories ||= []
      @categories << version if version != @categories.last
    end

    run.result.each do |key, value|
      if @comparing_runs.present?
        columns["#{key}_#{run.benchmark_type.category}"] ||= []
        columns["#{key}_#{run.benchmark_type.category}"] << [version, value.to_f]
      else
        columns[key] ||= []
        columns[key] << value.to_f
      end
    end
  end

  @columns = columns.map do |name, data|
    { name: name, data: data}
  end

  self
end

[SamSaffron]

@bmarkons @robin850 had some comments, can you be sure to address them and the merge conflict, I really want this merged into the repo and on the website as soon as possible.

We can refine it further in future PRs

[bmarkons]

sure @SamSaffron, I'm on it.

[bmarkons]

Thanks @robin850 :) I've made changes you've suggested.

[robin850]

@bmarkons : No problem, good job. Does the timeout change is related to the refactoring of the build_columns method ? The code I've given may be terribly inefficient.

[bmarkons]

@robin850 : No, that change doesn't affect performance. The code I've written in this PR is pretty much inefficient but I plan to make it better in next iteration.

[robin850]

Okay great, this can be shipped then ! 🙂 🎉