Skip to content
This repository has been archived by the owner on Mar 15, 2022. It is now read-only.

Updated README, rake tasks, and TravisCI build targets. #5

Merged
merged 1 commit into from
Jan 26, 2015
Merged

Conversation

jdantonio
Copy link
Member

Deprecate in lieu of Concurrent Ruby

Several months ago @headius suggested that the code in this gem be merged into Concurrent Ruby and this gem be deprecated. Subsequently we:

Recommendation

If the original plan discussed in Concurrent Ruby Issue #83 is still the plan then I recommend we merge this PR and make the final atomic release suggested by @headius back in May.

Thoughts? @headius @pitr-ch @mighe @chrisseaton @obrok @lucasallan

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 46c28be on docs into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b1b9901 on docs into * on master*.

@pitr-ch
Copy link
Member

pitr-ch commented Dec 8, 2014

It think we should allow users to load just what they need from concurrent-ruby eg. concurrent-ruby/atomic and document it here. Maybe bumping to 1.2 or 2.0 would be better since this is biggish change.

@jdantonio
Copy link
Member Author

This is also being discussed in a concurrent-ruby issue but I'm posting the answer here, too, for those who haven't read that other thread.

@pitr-ch Although it's not documented, we've always structured concurrent-ruby so that only a subset of the gem can be loaded. So require 'concurrent/atomic' should already work as you've suggested. We just need to update the documentation for that gem to be more explicit.

@jdantonio jdantonio changed the title Updated README, added badges, integrated Coveralls and Code Climate. Updated README, rake tasks, and TravisCI build targets. Jan 25, 2015
@jdantonio
Copy link
Member Author

We've released concurrent-ruby and concurrent-ruby-ext 0.8.0. Are there any objections to me merging this PR and publishing one final release of this gem?

@headius @pitr-ch @mighe @chrisseaton @obrok @lucasallan

@chrisseaton
Copy link
Member

Not from me.

@pitr-ch
Copy link
Member

pitr-ch commented Jan 26, 2015

No, go ahead 👍

@mighe
Copy link

mighe commented Jan 26, 2015

👍

@headius
Copy link
Contributor

headius commented Jan 26, 2015

Go for it. Did I give you the rights you need, or do I need to do something?

@jdantonio
Copy link
Member Author

@headius You shouldn't have to do anything. I just wanted to get everyone's buy-in before moving ahead.

jdantonio added a commit that referenced this pull request Jan 26, 2015
Updated README, rake tasks, and TravisCI build targets.
@jdantonio jdantonio merged commit b357135 into master Jan 26, 2015
@jdantonio jdantonio deleted the docs branch January 26, 2015 18:58
@jdantonio
Copy link
Member Author

Done! I've built the two gem packages and pushed them to Rubygems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants