This repository was archived by the owner on Mar 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Update readme and drop Ruby 1.8 support #30
Merged
lucasallan
merged 2 commits into
master
from
update-readme-removes-support-to-mri19-and-mri18
Mar 23, 2015
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are dropping 1.9 too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pitr-ch Yes, I believe there is no reason to support Ruby 1.9 in the next releases because MRI 1.9 is officially dead: https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for MRI 1.9 has ended, but I've never seen any data indicating that people aren't still using it in production. So I would hesitate to say it's actually dead. For this gem and this release I think dropping 1.9 support is OK. We aren't adding any new features or fixing bugs. The main goal of this release is to drop support for old versions of Ruby (mainly MRI 1.8 and IronRuby). MRI 1.9 users will still be able to use the 1.x release so we won't be disenfranchising any users. I would argue against dropping support for MRI 1.9 in any of our other gems, however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this gem our (
concurrent-ruby
) dependency? It would forceconcurrent-ruby
to 2.0 too, or am I mistaken? Also, We (Dynflow -> Foreman -> Katello) need 1.9 MRI still supported, since MRI 1.9 RPMs are supported. cc @iNecasThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pitr-ch Yes, you are correct. I completely lost sight of that when I post my previous response. The original suggestion in #22 was to drop support for MRI 1.8 and Iron Ruby and I think we should stick with that. My previous comment was in error. We should retain support for MRI in 1.9 until we are ready to remove MRI 1.9 support from concurrent-ruby. Thanks for catching that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#33