Skip to content

Conversation

tatsuyafw
Copy link
Contributor

Hi!

This PR contains the following fixes for RuboCop:

…mentIndentation` cop

The `Layout/IndentFirstHashElement` cop was renamed to `Layout/FirstHashElementIndentation` in RuboCop v0.77.0.
@grape-bot
Copy link

grape-bot commented Nov 28, 2019

1 Error
🚫 One of the lines below found in CHANGELOG.md doesn’t match the expected format. Please make it look like the other lines, pay attention to periods and spaces.
2 Warnings
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.
* [#307](https://github.com/ruby-grape/grape-entity/pull/307): Allow exposures to call methods defined in modules included in an entity [@robertoz-01](https://github.com/robertoz-01).

Here's an example of a CHANGELOG.md entry:

* [#326](https://github.com/ruby-grape/grape-entity/pull/326): Fix rubocop issues - [@tatsuyafw](https://github.com/tatsuyafw).

Generated by 🚫 danger

@coveralls
Copy link

coveralls commented Nov 28, 2019

Coverage Status

Coverage increased (+0.01%) to 95.864% when pulling adc29e1 on tatsuyafw:rubocop-fixes into 1515b25 on ruby-grape:master.

@LeFnord
Copy link
Member

LeFnord commented Dec 15, 2019

thanks @tatsuyafw

@LeFnord LeFnord merged commit cf146b7 into ruby-grape:master Dec 15, 2019
@tatsuyafw tatsuyafw deleted the rubocop-fixes branch December 16, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants