Fix mounting APIs in route_param namespaces #543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hopefully closes [ruby-grape#267](ruby-grape#267), which describes a scenario like: route_param :vendor do mount Endpoints::Events end The fix is very barebone but resolved the issue for me.
Here's an example of a CHANGELOG.md entry: * [#543](https://github.com/ruby-grape/grape-swagger/pull/543): Fix mounting APIs in route_param namespaces - [@milgner](https://github.com/milgner).Generated by 🚫 danger |
|
@LeFnord alright, no problem, I'll add specs and a Changelog entry (probably tomorrow evening). |
|
@milgner … some progress on it? |
|
hi @milgner … again, any progress on it, would be nice to mörge it |
This was referenced Sep 25, 2017
hara-y-u
pushed a commit
to hara-y-u/grape-swagger
that referenced
this pull request
Dec 8, 2017
* Fix mounting APIs in route_param namespaces * Added missing tests, based on code from ruby-grape#543 by @milgner Applied on top of latest master * Added changelog * Fix CHANGELOG.md * Cleanup rubocop offences related to this change * Fix rubocop version * Re-added * Your contribution here to CHANGELOG.md
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
* Fix mounting APIs in route_param namespaces * Added missing tests, based on code from ruby-grape#543 by @milgner Applied on top of latest master * Added changelog * Fix CHANGELOG.md * Cleanup rubocop offences related to this change * Fix rubocop version * Re-added * Your contribution here to CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully closes #267,
which describes a scenario like:
The fix is very barebone but resolved the issue for me. Please note that I don't have any idea what I'm doing 😉 Both Grape itself as well as the Swagger integration are very complex and the only thing I did was to look at exceptions and fix the incoming data in a way that would make them go away and finally generate some documentation 😆
Everything looks like it's supposed to look but there may be other scenarios that are failing now. So feel free to suggest improvements or add amendments as necessary.