Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content types registrable #2005

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Content types registrable #2005

merged 3 commits into from
Mar 5, 2020

Conversation

ericproulx
Copy link
Contributor

I found that Grape::ContentTypes ::CONTENT_TYPE was mutable but had a rubocop disable comment.

Since you have Util::Registrable, I found that it would be better to use that pattern instead of a mutable const.

Also, I moved content_type in grape folder since it wasn't module Util

@dblock dblock merged commit fbeedb6 into ruby-grape:master Mar 5, 2020
@dblock
Copy link
Member

dblock commented Mar 5, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericproulx @dblock