Skip to content

Reduced MatchData allocation #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2020
Merged

Reduced MatchData allocation #2015

merged 2 commits into from
Mar 16, 2020

Conversation

ericproulx
Copy link
Contributor 

# Based on our app

# master
allocated memory by class
-----------------------------------
  15730608  Hash
   6726012  String
   5870664  Array
   3079724  Regexp
    202016  MatchData
# this PR

allocated memory by class
-----------------------------------
  15730608  Hash
   6726012  String
   5870664  Array
   3079724  Regexp
     81024  Grape::Router::Route
     72936  Grape::Router::Pattern
     40520  Grape::Router::AttributeTranslator
     38960  Grape::Router::Any
     25840  Grape::Path
     23376  MatchData

@ericproulx
Replace =~ or match by match? when we don't need the MatchData object…
b37025c 
…. match? function is new from 2.4

Add CHANGELOG.md
@ericproulx ericproulx force-pushed the reduced_match_data_allocation branch from b0f6d5c to b37025c Compare March 16, 2020 13:43
@dblock dblock merged commit fc5afbc into ruby-grape:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @dblock