Add upgrade notice for Array[String] #2016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#2016](https://github.com/ruby-grape/grape/pull/2016): Add upgrade notice for array[string] - [@stanhu](https://github.com/stanhu).Generated by 🚫 danger |
stanhu
commented
Mar 16, 2020
stanhu
force-pushed
the
sh-improve-upgrade-guide
branch
from
db0fdd1 to
4516499
Compare
If Array[String] is used without a coerce_with block, existing APIs may quietly fail without explanation. This change to the upgrade documentation makes that clear. Closes ruby-grape#2013
stanhu
force-pushed
the
sh-improve-upgrade-guide
branch
from
4516499 to
5fd457c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Array[String]is used without acoerce_withblock, existing APIs mayquietly fail without explanation. This change to the upgrade
documentation makes that clear.
Closes #2013