Skip to set default value unless meets_dependency?
#2097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. |
Merged
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Grape::Validations::Base#validate!calls#validate_param!only if@scope.meets_dependency?(val, params)is truthy.But
Grape::Validations::DefaultValidator#validate!ignores the cope dependency now.It doesn't matter in most cases because of
@scope.should_validate?, but this is not the case for an array that contains both matching and non-matching conditions.So I guess
Grape::Validations::DefaultValidator#validate!should the check scope dependency as same asGrape::Validations::Base#validate!.How about it?