Timeout handler

[halostatue]

Originally submitted on RubyForge by Stefano Grioni (esox_ch) on 2008-12-14:

Hello,

I think that you should provide a method which allows people to set a timeout. Because if my LDAP server goes down and I use NET::LDAP I risk to see the whole Rails app stop as well, and I currently have no way to detect it and display any kind of message.

Thanks a lot

[halostatue]

Comment by Austin Ziegler on 2010-09-24:

We may want to investigate this pre-1.0.

[kotedo]

Is there any update on that? That's a long time to think! :)

—Kai

[omidmt]

Hi,

No news on it ?

BR

[biTshifT]

I would have thought that exposing the timeout length would be both simple, and important. I'm actually a little baffled as to why the timeout is not exposed, it seems an odd design decision?

[pawurb]

+1

[aaronchi]

+1

[lifeBCE]

+1

[mtodd]

To use the SearchRequest.timeLimit field, looks like we'd just need to wire up this param:

ruby-net-ldap/lib/net/ldap.rb

Line 1550 in 449370b

0.to_ber,

It might be worth separately looking at handling timeouts client side with Timeout.timeout, though that would be somewhat redundant since implementors could easily wrap calls with timeouts themselves. Seems the value here would be to implement the feature of the spec.

[aaronchi]

I'd like to get a timeout on the actual socket connection.

[mtodd]

@aaronchi feel that. Any input on where the timeouts make the most sense? TCPSocket#read and write calls?

It might make sense to make the socket class configurable so it can be wrapped as needed. This adds flexibility for timeouts, instrumentation, or customization, without having to hardcode timeouts in our library.

[aaronchi]

@mtodd I've looked at a couple of methods for adding timeout to TCPSocket
http://spin.atomicobject.com/2013/09/30/socket-connection-timeout-ruby/

All of them involve doing a connect_nonblock, but when I tried adding this, it seems to affect the ability of the connection to be wrapped in an SSLSocket. It seems like it might need to be added to TCPSocket or SSLSocket depending on whether the call is going to be wrapped in SSL.

[aaronchi]

There is also this gem that adds a lot of this functionality to TCPSocket but has the same issue when wrapping in SSL
https://github.com/reidmorrison/net_tcp_client