Skip to content

Conversation

jch
Copy link
Member

@jch jch commented Oct 24, 2014

This shows up whenever someone tries to file an issue.

@jch jch mentioned this pull request Oct 24, 2014
baz: 'garply'
```

[issues]: https://github.com/jch/html-pipeline/issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this to ruby-ldap/ruby-net-ldap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 78c3c42

@mtodd
Copy link
Member

mtodd commented Oct 24, 2014

Other than the comments above, looks great!


Pull requests will trigger automatic continuous integration builds on
[TravisCI][travis]. To run integration tests locally, see the `test/support`
folder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can link to the test/support directory with relative links.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't link this because it's an empty folder and doesn't reference well in GitHub UI.

jch added a commit that referenced this pull request Oct 27, 2014
@jch jch merged commit ce30b21 into master Oct 27, 2014
@jch jch deleted the add-contributing branch October 27, 2014 17:22
astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants