Skip to content

Fix uninitialised Net::LDAP::LdapPduError #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2020
Merged

Fix uninitialised Net::LDAP::LdapPduError #338

merged 1 commit into from
Jul 2, 2020

Conversation

Laykou
Copy link
Contributor

@Laykou Laykou commented Dec 12, 2019

Due to missing explicit name, the LdapPduError actually looked for Net::LDAP::PDU::LdapPduError class.

Even though the Net module has a missing constant method, it was not catched here.

The solution is to explicitly use Error classs.

HarlemSquirrel
HarlemSquirrel approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HarlemSquirrel HarlemSquirrel merged commit 30b5db4 into ruby-ldap:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laykou @HarlemSquirrel